kangkaisen commented on a change in pull request #3025: Restructure storage
type to support complex types expending
URL: https://github.com/apache/incubator-doris/pull/3025#discussion_r392284891
##########
File path: be/src/olap/rowset/segment_v2/bitshuffle_page.h
##########
@@ -334,6 +334,10 @@ class BitShufflePageDecoder : public PageDecoder {
}
Status next_batch(size_t* n, ColumnBlockView* dst) override {
+ return next_batch(n, dst, true);
+ }
+
+ Status next_batch(size_t* n, ColumnBlockView* dst, bool forward_index) {
Review comment:
For performance, we could use function template.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
