kangkaisen commented on a change in pull request #3025: Restructure storage
type to support complex types expending
URL: https://github.com/apache/incubator-doris/pull/3025#discussion_r392265602
##########
File path: be/src/olap/rowset/segment_v2/column_reader.h
##########
@@ -127,12 +127,26 @@ class ColumnReader {
PagePointer get_dict_page_pointer() const { return _meta.dict_page(); }
-private:
+ // do not call this method in classes other than subclasses of
ColumnReader and ColumnReader
Review comment:
```suggestion
// do not call this method in classes other than subclasses of
ColumnReader
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
