kangkaisen commented on a change in pull request #3025: Restructure storage
type to support complex types expending
URL: https://github.com/apache/incubator-doris/pull/3025#discussion_r392285900
##########
File path: be/src/olap/types.h
##########
@@ -106,12 +141,186 @@ class TypeInfo {
const size_t _size;
const FieldType _field_type;
- friend class TypeInfoResolver;
- template<typename TypeTraitsClass> TypeInfo(TypeTraitsClass t);
+ friend class ScalarTypeInfoResolver;
+ template<typename TypeTraitsClass> ScalarTypeInfo(TypeTraitsClass t);
+};
+
+class ListTypeInfo : public TypeInfo {
Review comment:
Please add a UT for `ListTypeInfo`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
