Seaven commented on a change in pull request #2979: Incomplete support Array
type (#2871)
URL: https://github.com/apache/incubator-doris/pull/2979#discussion_r386766810
##########
File path: fe/src/main/java/org/apache/doris/catalog/Type.java
##########
@@ -43,11 +43,8 @@
public abstract class Type {
private static final Logger LOG = LogManager.getLogger(Type.class);
- // Maximum nesting depth of a type. This limit was determined
experimentally by
- // generating and scanning deeply nested Parquet and Avro files. In those
experiments,
- // we exceeded the stack space in the scanner (which uses recursion for
dealing with
- // nested types) at a nesting depth between 200 and 300 (200 worked, 300
crashed).
- public static int MAX_NESTING_DEPTH = 100;
+ // Maximum nesting depth of a type.
Review comment:
Just limit the depth of nested types, deeper nested type require a lot of
extra development, and I don't think we need to support more than 2 depths,
like array<map<array<int>>>......
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
