morningman commented on a change in pull request #2979: Incomplete support 
Array type (#2871)
URL: https://github.com/apache/incubator-doris/pull/2979#discussion_r386450281
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/CreateTableStmt.java
 ##########
 @@ -350,6 +353,17 @@ public void analyze(Analyzer analyzer) throws 
UserException {
                 }
             }
 
+            if (columnDef.getType().isArrayType()) {
+                ArrayType tp =  (ArrayType) columnDef.getType();
+                if 
(!PrimitiveType.INT.equals(tp.getItemType().getPrimitiveType()) &&
 
 Review comment:
   PrimitiveType is enum class, so you can just using `==`
   like:
   ```
   tp.getItemType().getPrimitiveType() == PrimitiveType.INT
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to