Seaven commented on a change in pull request #2979: Incomplete support Array 
type (#2871)
URL: https://github.com/apache/incubator-doris/pull/2979#discussion_r386764936
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/catalog/ScalarType.java
 ##########
 @@ -141,6 +141,9 @@ public static ScalarType createType(PrimitiveType type) {
                 return DEFAULT_DECIMALV2;
             case LARGEINT:
                 return LARGEINT;
+            case ARRAY:
+                // can't static, because the same array may cause circular 
dependency
 
 Review comment:
   Nested type need decide sub-element type in runtime, return a static object 
will take repeatedly set the sub-element type of same object in many 
places......

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to