morningman commented on a change in pull request #2828: [Temp Partition]
Support add/drop/replace temp partitions
URL: https://github.com/apache/incubator-doris/pull/2828#discussion_r386069625
##########
File path: fe/src/main/java/org/apache/doris/qe/ShowExecutor.java
##########
@@ -1215,12 +1215,17 @@ private void handleShowTablet() throws
AnalysisException {
}
boolean stop = false;
Collection<Partition> partitions = new ArrayList<Partition>();
- List<String> partitionNames = showStmt.getPartitionNames();
if (showStmt.hasPartition()) {
- for (Partition partition : olapTable.getPartitions()) {
- if (partitionNames.contains(partition.getName())) {
- partitions.add(partition);
+ List<String> partitionNames = showStmt.getPartitionNames();
+ for (String partName : partitionNames) {
+ Partition partition = olapTable.getPartition(partName);
+ if (partition == null) {
Review comment:
I will reconsider this when implementing loading process of temp partition.
If I change the origin `getPartition` method, it may change lots of codes in
this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
