morningman commented on a change in pull request #2828: [Temp Partition]
Support add/drop/replace temp partitions
URL: https://github.com/apache/incubator-doris/pull/2828#discussion_r386068923
##########
File path: fe/src/main/java/org/apache/doris/catalog/OlapTable.java
##########
@@ -624,6 +632,14 @@ public Partition getPartition(String partitionName) {
return nameToPartition.get(partitionName);
}
+ public Partition getPartition(String partitionName, boolean
isTempPartition) {
Review comment:
If split into 2 methods, we have to write `if .. else ..` every time we call
`getPartition()`, which is not convenient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
