morningman commented on a change in pull request #2828: [Temp Partition] 
Support add/drop/replace temp partitions
URL: https://github.com/apache/incubator-doris/pull/2828#discussion_r386069047
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/catalog/OlapTable.java
 ##########
 @@ -1241,4 +1264,141 @@ public void setIsInMemory(boolean isInMemory) {
         
tableProperty.modifyTableProperties(PropertyAnalyzer.PROPERTIES_INMEMORY, 
Boolean.valueOf(isInMemory).toString());
         tableProperty.buildInMemory();
     }
+
+    // return true if partition with given name already exist, both in 
partitions and temp partitions.
+    // return false otherwise
+    public boolean checkPartitionNameExist(String partitionName) {
+        if (nameToPartition.containsKey(partitionName)) {
+            return true;
+        }
+        return tempPartitions.hasPartition(partitionName);
+    }
+
+    // if includeTempPartition is true, check if temp partition with given 
name exist,
+    // if includeTempPartition is false, check if temp partition with given 
name exist.
+    // return true if exist, otherwise, return false;
+    public boolean checkPartitionNameExist(String partitionName, boolean 
isTempPartition) {
 
 Review comment:
   Same reason as `getPartition`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to