imay commented on a change in pull request #2501: Support more schema change
from VARCHAR type
URL: https://github.com/apache/incubator-doris/pull/2501#discussion_r361049469
##########
File path: be/src/olap/types.h
##########
@@ -255,6 +255,19 @@ struct BaseFieldtypeTraits : public
CppTypeTraits<field_type> {
}
};
+#define CONVERT_FROM_VARCHAR(type_name, string_parser_fn) \
+ if (src_type->type() == OLAP_FIELD_TYPE_VARCHAR) { \
+ using SrcType = typename
CppTypeTraits<OLAP_FIELD_TYPE_VARCHAR>::CppType; \
+ auto src_value = *reinterpret_cast<const SrcType*>(src); \
+ StringParser::ParseResult parse_res; \
+ auto result = StringParser::string_parser_fn(src_value.get_data(),
src_value.get_size(), &parse_res); \
+ if (UNLIKELY(parse_res != StringParser::PARSE_SUCCESS ||
std::isnan(result) || std::isinf(result))) { \
+ return OLAPStatus::OLAP_ERR_INVALID_SCHEMA; \
+ } \
+ *reinterpret_cast<CppTypeTraits<type_name>::CppType*>(dest) =
result; \
+ return OLAPStatus::OLAP_SUCCESS; \
+ } \
Review comment:
last \ can be removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
