imay commented on a change in pull request #2501: Support more schema change
from VARCHAR type
URL: https://github.com/apache/incubator-doris/pull/2501#discussion_r361049046
##########
File path: be/src/olap/types.h
##########
@@ -280,6 +293,23 @@ struct FieldTypeTraits<OLAP_FIELD_TYPE_TINYINT> : public
BaseFieldtypeTraits<OLA
snprintf(buf, sizeof(buf), "%d", *reinterpret_cast<const
int8_t*>(src));
return std::string(buf);
}
+ static OLAPStatus convert_from(void* dest, const void* src, const
TypeInfo* src_type, MemPool* mem_pool) {
+ CONVERT_FROM_VARCHAR(OLAP_FIELD_TYPE_TINYINT,
string_to_int<CppTypeTraits<OLAP_FIELD_TYPE_TINYINT>::CppType>)
Review comment:
```suggestion
CONVERT_FROM_VARCHAR(OLAP_FIELD_TYPE_TINYINT,
string_to_int<CppTypeTraits<OLAP_FIELD_TYPE_TINYINT>::CppType>);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
