imay commented on a change in pull request #2501: Support more schema change
from VARCHAR type
URL: https://github.com/apache/incubator-doris/pull/2501#discussion_r361050100
##########
File path: be/src/olap/types.h
##########
@@ -255,6 +255,19 @@ struct BaseFieldtypeTraits : public
CppTypeTraits<field_type> {
}
};
+#define CONVERT_FROM_VARCHAR(type_name, string_parser_fn) \
Review comment:
Can you implement this in a template function other than a macro?
Using macro is error-prone, we should avoid this as far as we can
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
