reele commented on code in PR #17372:
URL:
https://github.com/apache/dolphinscheduler/pull/17372#discussion_r2241411234
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/executor/PhysicalTaskEngineDelegator.java:
##########
@@ -76,9 +78,14 @@ public boolean reassignWorkflowInstanceHost(final
TaskExecutorReassignMasterRequ
final int taskInstanceId =
taskExecutorReassignMasterRequest.getTaskInstanceId();
final String workflowHost =
taskExecutorReassignMasterRequest.getWorkflowHost();
// todo: Is this reassign can make sure there is no concurrent problem?
- physicalTaskExecutorRepository.get(taskInstanceId).ifPresent(
- taskExecutor ->
taskExecutor.getTaskExecutionContext().setWorkflowInstanceHost(workflowHost));
- return
physicalTaskExecutorEventReporter.reassignWorkflowInstanceHost(taskInstanceId,
workflowHost);
+ final Optional<ITaskExecutor> taskExecutorOptional =
physicalTaskExecutorRepository.get(taskInstanceId);
+
physicalTaskExecutorEventReporter.reassignWorkflowInstanceHost(taskInstanceId,
workflowHost);
+ if (taskExecutorOptional.isPresent()) {
+ final ITaskExecutor taskExecutor = taskExecutorOptional.get();
+
taskExecutor.getTaskExecutionContext().setWorkflowInstanceHost(workflowHost);
+ return true;
+ }
+ return false;
Review Comment:
> A TaskExecutor will only be removed after the
TaskExecutorFinalizeLifecycleEvent is fired, and this event should be fired in
synchronous mode.
so, how about moving the publishing of TaskExecutorFinalizeLifecycleEvent to
TaskExecutorLifecycleEventRemoteReporter? When a task reaches a terminal state
(Success/Killed/Paused/Failed), we could publish a new
TaskExecutorFinishedLifecycleEvent to mark the TaskExecutor as invalid. Then,
the final event TaskExecutorFinalizeLifecycleEvent would instead be published
by TaskExecutorLifecycleEventRemoteReporter.
I've submitted the new changes implemented according to this flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
