reele commented on code in PR #17372:
URL:
https://github.com/apache/dolphinscheduler/pull/17372#discussion_r2236439963
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/executor/PhysicalTaskEngineDelegator.java:
##########
@@ -76,9 +78,14 @@ public boolean reassignWorkflowInstanceHost(final
TaskExecutorReassignMasterRequ
final int taskInstanceId =
taskExecutorReassignMasterRequest.getTaskInstanceId();
final String workflowHost =
taskExecutorReassignMasterRequest.getWorkflowHost();
// todo: Is this reassign can make sure there is no concurrent problem?
- physicalTaskExecutorRepository.get(taskInstanceId).ifPresent(
- taskExecutor ->
taskExecutor.getTaskExecutionContext().setWorkflowInstanceHost(workflowHost));
- return
physicalTaskExecutorEventReporter.reassignWorkflowInstanceHost(taskInstanceId,
workflowHost);
+ final Optional<ITaskExecutor> taskExecutorOptional =
physicalTaskExecutorRepository.get(taskInstanceId);
+
physicalTaskExecutorEventReporter.reassignWorkflowInstanceHost(taskInstanceId,
workflowHost);
+ if (taskExecutorOptional.isPresent()) {
+ final ITaskExecutor taskExecutor = taskExecutorOptional.get();
+
taskExecutor.getTaskExecutionContext().setWorkflowInstanceHost(workflowHost);
+ return true;
+ }
+ return false;
Review Comment:
yes, i mean, i did test for get host address from TaskExecutor, when
reporter handle the failed or other final events, the taskExecutor is already
removed from repository.
assembly the host to channel is ok, i didn't find a good way to passing host
to channel(if remove host from event), i'm still doing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
