github-advanced-security[bot] commented on code in PR #17372:
URL:
https://github.com/apache/dolphinscheduler/pull/17372#discussion_r2241485372
##########
dolphinscheduler-extract/dolphinscheduler-extract-master/src/main/java/org/apache/dolphinscheduler/extract/master/TaskExecutorEventRemoteReporterClient.java:
##########
@@ -33,32 +33,38 @@
@Slf4j
public class TaskExecutorEventRemoteReporterClient implements
ITaskExecutorEventRemoteReporterClient {
- public void reportTaskExecutionEventToMaster(final
IReportableTaskExecutorLifecycleEvent taskExecutorLifecycleEvent) {
+ public void reportTaskExecutionEventToMaster(final String masterAddress,
Review Comment:
## Missing Override annotation
This method overrides
[ITaskExecutorEventRemoteReporterClient.reportTaskExecutionEventToMaster](1);
it is advisable to add an Override annotation.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/5488)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
