ruanwenjun commented on code in PR #16838:
URL:
https://github.com/apache/dolphinscheduler/pull/16838#discussion_r1858093450
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java:
##########
@@ -1438,7 +1437,7 @@ private TaskDefinitionLog
buildNormalSqlTaskDefinition(String taskName, DataSour
sqlParameters.setLocalParams(Collections.emptyList());
taskDefinition.setTaskParams(JSONUtils.toJsonString(sqlParameters));
taskDefinition.setCode(CodeGenerateUtils.genCode());
- taskDefinition.setTaskType(SqlTaskChannelFactory.NAME);
+ taskDefinition.setTaskType("SQL");
Review Comment:
Please link issue to track this.
##########
tools/dependencies/known-dependencies.txt:
##########
@@ -91,18 +76,8 @@ hadoop-yarn-client-3.2.4.jar
hadoop-yarn-common-3.2.4.jar
hbase-noop-htrace-4.1.1.jar
hibernate-validator-6.2.2.Final.jar
-hive-common-2.3.9.jar
-hive-jdbc-2.3.9.jar
-hive-metastore-2.3.9.jar
-hive-serde-2.3.9.jar
-hive-service-2.3.9.jar
-hive-service-rpc-2.3.9.jar
-hive-storage-api-2.4.0.jar
-httpasyncclient-4.1.5.jar
Review Comment:
This lib will not exist on binary package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
