SbloodyS commented on code in PR #16838:
URL: 
https://github.com/apache/dolphinscheduler/pull/16838#discussion_r1857652687


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java:
##########
@@ -1438,7 +1437,7 @@ private TaskDefinitionLog 
buildNormalSqlTaskDefinition(String taskName, DataSour
         sqlParameters.setLocalParams(Collections.emptyList());
         taskDefinition.setTaskParams(JSONUtils.toJsonString(sqlParameters));
         taskDefinition.setCode(CodeGenerateUtils.genCode());
-        taskDefinition.setTaskType(SqlTaskChannelFactory.NAME);
+        taskDefinition.setTaskType("SQL");

Review Comment:
   This function is useless, I will remove this piece in other PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to