ruanwenjun commented on code in PR #16838:
URL:
https://github.com/apache/dolphinscheduler/pull/16838#discussion_r1856295123
##########
dolphinscheduler-api/pom.xml:
##########
@@ -63,13 +63,19 @@
<dependency>
<groupId>org.apache.dolphinscheduler</groupId>
- <artifactId>dolphinscheduler-datasource-all</artifactId>
+ <artifactId>dolphinscheduler-common</artifactId>
Review Comment:
It's better to change `dolphinscheduler-datasource-all` to provided rather
than remove it, once we remove it, no one can find the module relation.
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java:
##########
@@ -1438,7 +1437,7 @@ private TaskDefinitionLog
buildNormalSqlTaskDefinition(String taskName, DataSour
sqlParameters.setLocalParams(Collections.emptyList());
taskDefinition.setTaskParams(JSONUtils.toJsonString(sqlParameters));
taskDefinition.setCode(CodeGenerateUtils.genCode());
- taskDefinition.setTaskType(SqlTaskChannelFactory.NAME);
+ taskDefinition.setTaskType("SQL");
Review Comment:
We need to use enum or constant, otherwise once the type has been changed,
it's hard to know we need to make change here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
