This is an automated email from the ASF dual-hosted git repository. aherbert pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-statistics.git
commit 8a18aba1466dea13ddb538b85b4e047e602064e5 Author: aherbert <aherb...@apache.org> AuthorDate: Fri Jul 30 12:21:40 2021 +0100 Use divide for accuracy rather than multiply by reciprocal --- .../commons/statistics/distribution/UniformDiscreteDistribution.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/UniformDiscreteDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/UniformDiscreteDistribution.java index 8b1f4ae..7a3e691 100644 --- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/UniformDiscreteDistribution.java +++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/UniformDiscreteDistribution.java @@ -25,8 +25,6 @@ import org.apache.commons.rng.sampling.distribution.DiscreteUniformSampler; * uniform integer distribution</a>. */ public class UniformDiscreteDistribution extends AbstractDiscreteDistribution { - /** 1 / 12. **/ - private static final double ONE_TWELFTH = 1 / 12d; /** Lower bound (inclusive) of this distribution. */ private final int lower; /** Upper bound (inclusive) of this distribution. */ @@ -94,7 +92,7 @@ public class UniformDiscreteDistribution extends AbstractDiscreteDistribution { */ @Override public double getVariance() { - return ONE_TWELFTH * (upperMinusLowerPlus1 * upperMinusLowerPlus1 - 1); + return (upperMinusLowerPlus1 * upperMinusLowerPlus1 - 1) / 12; } /**