This is an automated email from the ASF dual-hosted git repository. aherbert pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-statistics.git
commit cbc4298809b24af9144d6024d593dbb1963d42d4 Author: aherbert <aherb...@apache.org> AuthorDate: Fri Jul 30 15:26:36 2021 +0100 Fix inverseCumulativeProbability --- .../apache/commons/statistics/distribution/LogisticDistribution.java | 4 ++-- .../commons/statistics/distribution/LogisticDistributionTest.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LogisticDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LogisticDistribution.java index 522ccda..7bbdebd 100644 --- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LogisticDistribution.java +++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LogisticDistribution.java @@ -104,9 +104,9 @@ public class LogisticDistribution extends AbstractContinuousDistribution { p > 1) { throw new DistributionException(DistributionException.INVALID_PROBABILITY, p); } else if (p == 0) { - return 0; + return SUPPORT_LO; } else if (p == 1) { - return Double.POSITIVE_INFINITY; + return SUPPORT_HI; } else { return scale * Math.log(p / (1 - p)) + mu; } diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LogisticDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LogisticDistributionTest.java index 60e7cfe..a6d1de5 100644 --- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LogisticDistributionTest.java +++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LogisticDistributionTest.java @@ -81,7 +81,7 @@ class LogisticDistributionTest extends ContinuousDistributionAbstractTest { @Test void testInverseCumulativeProbabilityExtremes() { setInverseCumulativeTestPoints(new double[] {0, 1}); - setInverseCumulativeTestValues(new double[] {0, Double.POSITIVE_INFINITY}); + setInverseCumulativeTestValues(new double[] {Double.NEGATIVE_INFINITY, Double.POSITIVE_INFINITY}); verifyInverseCumulativeProbabilities(); }