[commons-statistics] 08/22: Remove cache of upper + lower

[aherbert]

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git

commit 383c7db9ebca6bf071f564f5f7dd01a66c02daf7
Author: aherbert <aherb...@apache.org>
AuthorDate: Fri Jul 30 12:17:10 2021 +0100

    Remove cache of upper + lower
---
 .../statistics/distribution/UniformDiscreteDistribution.java        | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git 
a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/UniformDiscreteDistribution.java
 
b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/UniformDiscreteDistribution.java
index 9fce06e..8b1f4ae 100644
--- 
a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/UniformDiscreteDistribution.java
+++ 
b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/UniformDiscreteDistribution.java
@@ -31,8 +31,6 @@ public class UniformDiscreteDistribution extends 
AbstractDiscreteDistribution {
     private final int lower;
     /** Upper bound (inclusive) of this distribution. */
     private final int upper;
-    /** "upper" + "lower" (as a double to avoid overflow). */
-    private final double upperPlusLower;
     /** "upper" - "lower" + 1 (as a double to avoid overflow). */
     private final double upperMinusLowerPlus1;
 
@@ -52,7 +50,6 @@ public class UniformDiscreteDistribution extends 
AbstractDiscreteDistribution {
         }
         this.lower = lower;
         this.upper = upper;
-        upperPlusLower = (double) upper + (double) lower;
         upperMinusLowerPlus1 = (double) upper - (double) lower + 1;
     }
 
@@ -85,7 +82,8 @@ public class UniformDiscreteDistribution extends 
AbstractDiscreteDistribution {
      */
     @Override
     public double getMean() {
-        return 0.5 * upperPlusLower;
+        // Avoid overflow
+        return 0.5 * ((double) upper + (double) lower);
     }
 
     /**