This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git
commit 303bbaffbd1de9ec19c7348e15bcf1a5a5282fdc
Author: Gary D. Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Jul 19 09:07:24 2025 -0400
Don't use underscores in local variable names
---
.../org/apache/commons/codec/binary/BinaryCodec.java | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/main/java/org/apache/commons/codec/binary/BinaryCodec.java
b/src/main/java/org/apache/commons/codec/binary/BinaryCodec.java
index c64b6e53..83ccf129 100644
--- a/src/main/java/org/apache/commons/codec/binary/BinaryCodec.java
+++ b/src/main/java/org/apache/commons/codec/binary/BinaryCodec.java
@@ -151,21 +151,21 @@ public class BinaryCodec implements BinaryDecoder,
BinaryEncoder {
}
final int rawLength = raw.length;
// get 8 times the bytes with 3 bit shifts to the left of the length
- final byte[] l_ascii = new byte[rawLength << 3];
+ final byte[] ascii = new byte[rawLength << 3];
/*
* We decr index jj by 8 as we go along to not recompute indices using
multiplication every time inside the
* loop.
*/
- for (int ii = 0, jj = l_ascii.length - 1; ii < rawLength; ii++, jj -=
8) {
+ for (int ii = 0, jj = ascii.length - 1; ii < rawLength; ii++, jj -= 8)
{
for (int bits = 0; bits < BITS.length; ++bits) {
if ((raw[ii] & BITS[bits]) == 0) {
- l_ascii[jj - bits] = '0';
+ ascii[jj - bits] = '0';
} else {
- l_ascii[jj - bits] = '1';
+ ascii[jj - bits] = '1';
}
}
}
- return l_ascii;
+ return ascii;
}
/**
@@ -182,21 +182,21 @@ public class BinaryCodec implements BinaryDecoder,
BinaryEncoder {
}
final int rawLength = raw.length;
// get 8 times the bytes with 3 bit shifts to the left of the length
- final char[] l_ascii = new char[rawLength << 3];
+ final char[] ascii = new char[rawLength << 3];
/*
* We decr index jj by 8 as we go along to not recompute indices using
multiplication every time inside the
* loop.
*/
- for (int ii = 0, jj = l_ascii.length - 1; ii < rawLength; ii++, jj -=
8) {
+ for (int ii = 0, jj = ascii.length - 1; ii < rawLength; ii++, jj -= 8)
{
for (int bits = 0; bits < BITS.length; ++bits) {
if ((raw[ii] & BITS[bits]) == 0) {
- l_ascii[jj - bits] = '0';
+ ascii[jj - bits] = '0';
} else {
- l_ascii[jj - bits] = '1';
+ ascii[jj - bits] = '1';
}
}
}
- return l_ascii;
+ return ascii;
}
/**
