This is an automated email from the ASF dual-hosted git repository. ggregory pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-codec.git
from d08da755 Add PMD check to the default Maven goal new cd4caaf3 Remove no longer used Checkstyle exclusion new 8c7fcfe1 Javadoc new 45f549ca Javadoc new 20df4c9f Fix SpotBugs [ERROR] Medium: org.apache.commons.codec.binary.BaseNCodec$AbstractBuilder.setEncodeTable(byte[]) may expose internal representation by storing an externally mutable object into BaseNCodec$AbstractBuilder.encodeTable [org.apache.commons.codec.binary.BaseNCodec$AbstractBuilder] At BaseNCodec.java:[line 131] EI_EXPOSE_REP2 new f49428a2 The method org.apache.commons.codec.binary.BaseNCodec.AbstractBuilder.setLineSeparator(byte...) now makes a defensive copy new d641319b org.apache.commons.codec.language.bm.PhoneticEngine.applyFinalRules(PhonemeBuilder, Map<String, List<Rule>>) new 163e8fcc Avoid unnecessary String conversion in org.apache.commons.codec.language.bm.PhoneticEngine.applyFinalRules(PhonemeBuilder, Map<String, List<Rule>>) new 46e8cdc5 Javadoc new 96610734 This old tweak doesn't satisfy FindBugs new 9c117905 Fix SpotBugs [ERROR] High: Potentially dangerous use of non-short-circuit logic in org.apache.commons.codec.language.DaitchMokotoffSoundex.cleanup(String) [org.apache.commons.codec.language.DaitchMokotoffSoundex] At DaitchMokotoffSoundex.java:[line 350] NS_DANGEROUS_NON_SHORT_CIRCUIT new 8ad83cb1 This old tweak doesn't satisfy FindBugs new 9e76e7f7 Remove some redundant keywords new ea130402 Remove some redundant keywords new 0f2dccc7 Add SpotBugs exclusion filter new 699b0a64 Add SpotBugs check to the default Maven goal new 303bbaff Don't use underscores in local variable names new 4c0174fe Javadoc The 17 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: pom.xml | 9 +- src/changes/changes.xml | 5 + src/conf/pmd.xml | 1 - src/conf/spotbugs-exclude-filter.xml | 101 +++++++++++ .../org/apache/commons/codec/binary/Base64.java | 3 +- .../apache/commons/codec/binary/BaseNCodec.java | 11 +- .../apache/commons/codec/binary/BinaryCodec.java | 20 +-- .../apache/commons/codec/digest/MurmurHash3.java | 185 ++++++++++++++------- .../apache/commons/codec/digest/PureJavaCrc32.java | 2 - .../commons/codec/digest/PureJavaCrc32C.java | 2 - .../commons/codec/language/AbstractCaverphone.java | 6 +- .../apache/commons/codec/language/Caverphone.java | 14 +- .../apache/commons/codec/language/Caverphone1.java | 4 +- .../apache/commons/codec/language/Caverphone2.java | 4 +- .../commons/codec/language/ColognePhonetic.java | 6 +- .../codec/language/DaitchMokotoffSoundex.java | 34 ++-- .../commons/codec/language/DoubleMetaphone.java | 28 ++-- .../codec/language/MatchRatingApproachEncoder.java | 38 ++--- .../apache/commons/codec/language/Metaphone.java | 25 ++- .../org/apache/commons/codec/language/Nysiis.java | 43 ++--- .../commons/codec/language/RefinedSoundex.java | 28 ++-- .../org/apache/commons/codec/language/Soundex.java | 65 +++----- .../commons/codec/language/SoundexUtils.java | 4 +- .../org/apache/commons/codec/language/bm/Lang.java | 4 +- .../commons/codec/language/bm/PhoneticEngine.java | 2 +- .../org/apache/commons/codec/language/bm/Rule.java | 20 +-- 26 files changed, 406 insertions(+), 258 deletions(-) create mode 100644 src/conf/spotbugs-exclude-filter.xml