(commons-codec) 10/17: Fix SpotBugs [ERROR] High: Potentially dangerous use of non-short-circuit logic in org.apache.commons.codec.language.DaitchMokotoffSoundex.cleanup(String) [org.apache.commons.codec.language.DaitchMokotoffSoundex] At DaitchMokotoffSoundex.java:[line 350] NS_DANGEROUS_NON_SHORT_CIRCUIT

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git

commit 9c117905ebee09e52d54cf25fb4f27ee66258ebd
Author: Gary D. Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Jul 19 08:28:52 2025 -0400

    Fix SpotBugs [ERROR] High: Potentially dangerous use of
    non-short-circuit logic in 
org.apache.commons.codec.language.DaitchMokotoffSoundex.cleanup(String)
    [org.apache.commons.codec.language.DaitchMokotoffSoundex] At
    DaitchMokotoffSoundex.java:[line 350] NS_DANGEROUS_NON_SHORT_CIRCUIT
---
 src/changes/changes.xml                                                 | 1 +
 .../java/org/apache/commons/codec/language/DaitchMokotoffSoundex.java   | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index fb8a3207..45123261 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -66,6 +66,7 @@ The <action> type attribute can be add,update,fix,remove.
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix SpotBugs 
[ERROR] Medium: 
org.apache.commons.codec.binary.BaseNCodec$AbstractBuilder.setEncodeTable(byte[])
 may expose internal representation by storing an externally mutable object 
into BaseNCodec$AbstractBuilder.encodeTable 
[org.apache.commons.codec.binary.BaseNCodec$AbstractBuilder] At 
BaseNCodec.java:[line 131] EI_EXPOSE_REP2.</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory">The method 
org.apache.commons.codec.binary.BaseNCodec.AbstractBuilder.setLineSeparator(byte...)
 now makes a defensive copy.</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Avoid 
unnecessary String conversion in 
org.apache.commons.codec.language.bm.PhoneticEngine.applyFinalRules(PhonemeBuilder,
 Map).</action>
+      <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix SpotBugs 
[ERROR] High: Potentially dangerous use of non-short-circuit logic in 
org.apache.commons.codec.language.DaitchMokotoffSoundex.cleanup(String) 
[org.apache.commons.codec.language.DaitchMokotoffSoundex] At 
DaitchMokotoffSoundex.java:[line 350] NS_DANGEROUS_NON_SHORT_CIRCUIT.</action>
       <!-- ADD -->
       <action type="add" dev="ggregory" due-to="Gary Gregory">Add 
HmacUtils.hmac(Path).</action>      
       <action type="add" dev="ggregory" due-to="Gary Gregory">Add 
HmacUtils.hmacHex(Path).</action>      
diff --git 
a/src/main/java/org/apache/commons/codec/language/DaitchMokotoffSoundex.java 
b/src/main/java/org/apache/commons/codec/language/DaitchMokotoffSoundex.java
index c5fc9652..d00d2474 100644
--- a/src/main/java/org/apache/commons/codec/language/DaitchMokotoffSoundex.java
+++ b/src/main/java/org/apache/commons/codec/language/DaitchMokotoffSoundex.java
@@ -347,7 +347,7 @@ public class DaitchMokotoffSoundex implements StringEncoder 
{
     private String cleanup(final String input) {
         final StringBuilder sb = new StringBuilder();
         for (char ch : input.toCharArray()) {
-            if (Character.isWhitespace(ch) | !Character.isLetter(ch)) {
+            if (Character.isWhitespace(ch) || !Character.isLetter(ch)) {
                 continue;
             }
             ch = Character.toLowerCase(ch);