Re: [PR] Minor fixes on env vars and runtime for kubernetes [camel-karavan]

[via GitHub]

thgruiz commented on code in PR #1389:
URL: https://github.com/apache/camel-karavan/pull/1389#discussion_r1736426023


##########
karavan-app/src/main/resources/configuration/kubernetes/build.sh:
##########
@@ -13,7 +13,7 @@ git clone --depth 1 --branch $GIT_BRANCH $GIT_REPOSITORY 
$CODE_DIR
 
 cd $CODE_DIR/$PROJECT_ID
 
-jbang -Dcamel.jbang.version=$CAMEL_VERSION camel@apache/camel export 
--local-kamelet-dir=$KAMELETS_DIR
+jbang -Dcamel.jbang.version=$CAMEL_VERSION camel@apache/camel export 
--local-kamelet-dir=$KAMELETS_DIR --runtime=${CAMEL_JBANG_RUNTIME:-camel-main}

Review Comment:
   @davsclaus , thanks for the reply!
   
   I just built the main branch (commit 
a1b0c339b7f355cbab71012d2d0f436573ed9ea5) and got the same error without the 
--runtime parameter
   
   
![image](https://github.com/user-attachments/assets/e9c2a605-fa5f-48d2-976f-ef757c66baf6)
   
   
   sorry, but where is this 4.8.0 version?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org