mgubaidullin commented on code in PR #1389:
URL: https://github.com/apache/camel-karavan/pull/1389#discussion_r1738938702
##########
karavan-app/src/main/docker/Dockerfile:
##########
@@ -26,14 +26,16 @@ RUN mkdir /opt/app
COPY target/*-runner.jar /opt/app/karavan.jar
ENV JAVA_OPTS="-Dquarkus.http.host=0.0.0.0
-Djava.util.logging.manager=org.jboss.logmanager.LogManager -XX:-UseG1GC
-XX:+UseZGC"
EXPOSE 8080
-CMD ["java", \
- "--add-modules", "java.se", \
- "--add-exports", "java.base/jdk.internal.ref=ALL-UNNAMED", \
- "--add-opens", "java.base/java.lang=ALL-UNNAMED", \
- "--add-opens", "java.base/java.nio=ALL-UNNAMED", \
- "--add-opens", "java.base/sun.nio.ch=ALL-UNNAMED", \
- "--add-opens", "java.management/sun.management=ALL-UNNAMED", \
- "--add-opens",
"jdk.management/com.ibm.lang.management.internal=ALL-UNNAMED", \
- "--add-opens", "jdk.management/com.sun.management.internal=ALL-UNNAMED", \
- "-jar", "/opt/app/karavan.jar"]
+
+CMD exec "java" \
+ ${JAVA_OPTS} \
+ "--add-modules" "java.se", \
Review Comment:
yes. All these
```
"--add-modules", "java.se", \
"--add-exports", "java.base/jdk.internal.ref=ALL-UNNAMED", \
"--add-opens", "java.base/java.lang=ALL-UNNAMED", \
"--add-opens", "java.base/java.nio=ALL-UNNAMED", \
"--add-opens", "java.base/sun.nio.ch=ALL-UNNAMED", \
"--add-opens", "java.management/sun.management=ALL-UNNAMED", \
"--add-opens",
"jdk.management/com.ibm.lang.management.internal=ALL-UNNAMED", \
"--add-opens", "jdk.management/com.sun.management.internal=ALL-UNNAMED",
```
changes are related to Hazelcast and need to be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
