thgruiz opened a new pull request, #1389: URL: https://github.com/apache/camel-karavan/pull/1389
First of all: this is an awesome project! This commits changes the following: 1) The vars on k8s deployment of the karavan-app As all variables were lowercase, quarkus did not see them, resulting in errors (like not finding the git repo's URL) 2) Adds the JAVA_OPTS unused var to the command line used to run karavan-app The var was been defined on the Dockerfile, but not used on the final command With this change, It was replaced the docker 'exec form' with the 'shell form' so we can use the env var (or else we could not use it, as it has multiple values). I took caution to use the exec command to replace the shell by the java process (so it continues to receive OS signals) 3) Adds a default runtime to the build.sh script for k8s, or else when creating an integration using only the karavan-app on k8s (did not tested with vscode extension) de build was failing with 'The runtime option must be specified' There are more stuff that I wish to contribute (for example: there is an error on git checkout when the repo's HEAD does not exist, even if we would not use it ), but let's see if those simple ones here are accepted first :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
