lburgazzoli commented on code in PR #5270:
URL: https://github.com/apache/camel-k/pull/5270#discussion_r1535376558
##########
pkg/trait/logging.go:
##########
@@ -80,6 +91,30 @@ func (l loggingTrait) Apply(e *Environment) error {
envvar.SetVal(&e.EnvVars, envVarQuarkusConsoleColor,
True)
}
}
+}
- return nil
+func (l loggingTrait) setCatalogConfiguration(e *Environment) {
+ if e.ApplicationProperties == nil {
+ e.ApplicationProperties = make(map[string]string)
+ }
+ e.ApplicationProperties["camel.k.logging.level"] = l.Level
Review Comment:
I don't think I follow, what I mean is that instead of doing this:
```go
e.ApplicationProperties["camel.k.logging.level"] = l.Level
```
We can leverage the tags defined on the go struct:
```go
e.ApplicationProperties[GetProperty(l.Level)] = l.Level
```
Which can be further improved with reflection.
It should only impact the go code and eventually the documentation but not
the CRDs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
