lburgazzoli commented on code in PR #5270:
URL: https://github.com/apache/camel-k/pull/5270#discussion_r1535337743
##########
pkg/trait/logging.go:
##########
@@ -80,6 +91,30 @@ func (l loggingTrait) Apply(e *Environment) error {
envvar.SetVal(&e.EnvVars, envVarQuarkusConsoleColor,
True)
}
}
+}
- return nil
+func (l loggingTrait) setCatalogConfiguration(e *Environment) {
+ if e.ApplicationProperties == nil {
+ e.ApplicationProperties = make(map[string]string)
+ }
+ e.ApplicationProperties["camel.k.logging.level"] = l.Level
Review Comment:
not for this first iteration but we could leverage tags, i.e:
```go
type Logging struct {
Level string `property:"camel.k.logging.level"`
}
```
So the mapping trait -> properties could be made generic and most of the
time, not manually hadn crafted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
