squakez commented on code in PR #5270:
URL: https://github.com/apache/camel-k/pull/5270#discussion_r1535370233
##########
pkg/trait/logging.go:
##########
@@ -80,6 +91,30 @@ func (l loggingTrait) Apply(e *Environment) error {
envvar.SetVal(&e.EnvVars, envVarQuarkusConsoleColor,
True)
}
}
+}
- return nil
+func (l loggingTrait) setCatalogConfiguration(e *Environment) {
+ if e.ApplicationProperties == nil {
+ e.ApplicationProperties = make(map[string]string)
+ }
+ e.ApplicationProperties["camel.k.logging.level"] = l.Level
Review Comment:
Yeah. However the problem there could be how it affects the API. IIUC the
conversion would happen when translating the CamelCatalog into a CR. We had
included the trait configuration some time ago, making the CRD longer than
probably should be. I wonder if adding more stuff may reach some limit that can
put us in troubles. In any case, some future challenge we will tackle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
