squakez commented on code in PR #4942: URL: https://github.com/apache/camel-k/pull/4942#discussion_r1423825891
########## pkg/apis/camel/v1/integration_types_support.go: ########## @@ -25,8 +25,18 @@ import ( metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" ) +// IntegrationLabel is used to tag k8s object created by a given Integration. const IntegrationLabel = "camel.apache.org/integration" +// IntegrationSyntheticLabel is used to tag k8s synthetic Integrations. +const IntegrationSyntheticLabel = "camel.apache.org/is-synthetic" + +// IntegrationImportedKindLabel specifies from what kind of resource an Integration was imported. +const IntegrationImportedKindLabel = "camel.apache.org/imported-from-kind" Review Comment: That's something I left out on purpose. I thought that once the user imports an Integration, he wants to control the lifecycle as well. If we link the lifecycle of the Integration to the Deployment, then the "Application Missing" makes no sense as the Integration would be garbage collected accordingly. It's not a strong opinion though, so, if we think it makes sense to do it, I can work on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org