lburgazzoli commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1423663352


##########
pkg/apis/camel/v1/integration_types_support.go:
##########
@@ -25,8 +25,18 @@ import (
        metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
+// IntegrationLabel is used to tag k8s object created by a given Integration.
 const IntegrationLabel = "camel.apache.org/integration"
 
+// IntegrationSyntheticLabel is used to tag k8s synthetic Integrations.
+const IntegrationSyntheticLabel = "camel.apache.org/is-synthetic"
+
+// IntegrationImportedKindLabel specifies from what kind of resource an 
Integration was imported.
+const IntegrationImportedKindLabel = "camel.apache.org/imported-from-kind"

Review Comment:
   maybe we can use ownership here  so the resource is also the owner of the 
synthetic integration and can get deleted by kubernetes gc ? it could also 
simplify the reconciler as you probably won't need to delete the resource 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to