[GitHub] [camel-k] orpiske commented on a change in pull request #2138: fix: change prioritization of the insecure flag check to ensure it works with mixed secure/insecure registries

[GitBox]

orpiske commented on a change in pull request #2138:
URL: https://github.com/apache/camel-k/pull/2138#discussion_r595189384



##########
File path: pkg/trait/builder.go
##########
@@ -256,7 +256,10 @@ func (t *builderTrait) buildahTask(e *Environment) 
(*v1.ImageTask, error) {
        }
 
        var auth string
-       if e.Platform.Status.Build.Registry.Secret != "" {
+       if e.Platform.Status.Build.Registry.Insecure {

Review comment:
       @astefanutti oh, I got your point. That's a very good one and I agree 
with you that it should be streamlined so that it behaves the same on this 
strategy as well. IMHO, we could align to the way we are doing with Kaniko. 
What do you think? If you are fine with it, I will adjust it that way. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org