[GitHub] [camel-k] astefanutti commented on a change in pull request #2138: fix: change prioritization of the insecure flag check to ensure it works with mixed secure/insecure registries

[GitBox]

astefanutti commented on a change in pull request #2138:
URL: https://github.com/apache/camel-k/pull/2138#discussion_r595162476



##########
File path: pkg/trait/builder.go
##########
@@ -256,7 +256,10 @@ func (t *builderTrait) buildahTask(e *Environment) 
(*v1.ImageTask, error) {
        }
 
        var auth string
-       if e.Platform.Status.Build.Registry.Secret != "" {
+       if e.Platform.Status.Build.Registry.Insecure {

Review comment:
       I wonder how symmetrical it is or should be with what's done with 
Kaniko? For the later, we've decided to de-correlate the two options, so we may 
want to do the same for Buildah. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org