astefanutti commented on a change in pull request #2138:
URL: https://github.com/apache/camel-k/pull/2138#discussion_r595178581
##########
File path: pkg/trait/builder.go
##########
@@ -256,7 +256,10 @@ func (t *builderTrait) buildahTask(e *Environment)
(*v1.ImageTask, error) {
}
var auth string
- if e.Platform.Status.Build.Registry.Secret != "" {
+ if e.Platform.Status.Build.Registry.Insecure {
Review comment:
Sorry, I meant for Kaniko, we are doing:
```go
if e.Platform.Status.Build.Registry.Secret != "" {
}
if e.Platform.Status.Build.Registry.Insecure {
}
```
While here we propose:
```go
if e.Platform.Status.Build.Registry.Insecure {
}
} else if e.Platform.Status.Build.Registry.Secret != "" {
}
```
I would find it logical to chose a strategy and apply the same for Kaniko
and Buildah.
##########
File path: pkg/trait/builder.go
##########
@@ -256,7 +256,10 @@ func (t *builderTrait) buildahTask(e *Environment)
(*v1.ImageTask, error) {
}
var auth string
- if e.Platform.Status.Build.Registry.Secret != "" {
+ if e.Platform.Status.Build.Registry.Insecure {
Review comment:
Sorry, I meant for Kaniko, we are doing:
```go
if e.Platform.Status.Build.Registry.Secret != "" {
}
if e.Platform.Status.Build.Registry.Insecure {
}
```
While here we propose:
```go
if e.Platform.Status.Build.Registry.Insecure {
}
} else if e.Platform.Status.Build.Registry.Secret != "" {
}
```
I would find it logical to choose a strategy and apply the same for Kaniko
and Buildah.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
