sivakumar-mahalingam commented on code in PR #4392:
URL: https://github.com/apache/amoro/pull/4392#discussion_r4303891131
##########
amoro-ams/src/test/java/org/apache/amoro/server/optimizing/TestIcebergV3OptimizingPlanning.java:
##########
@@ -69,23 +71,43 @@
import org.junit.jupiter.params.provider.ValueSource;
import java.nio.file.Path;
+import java.sql.PreparedStatement;
+import java.sql.SQLException;
import java.util.Arrays;
import java.util.Collections;
+import java.util.HashSet;
+import java.util.Set;
import java.util.stream.Collectors;
class TestIcebergV3OptimizingPlanning extends PersistentBase {
@TempDir private Path temp;
+ // Preserve standalone execution without loading DerbyPersistence when the
shared AMS test
+ // environment has already initialized persistence. Loading it would
truncate the shared DB.
+ @SuppressWarnings("unused")
Review Comment:
These AMS fixes are unrelated to Spark 4.1 and were extracted into #4394,
which has merged. They still appear here because this branch retains the
earlier merge base. I’ll update the branch and drop the redundant AMS commits
while preserving the upstream fixes and Spark optimizer tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
