xxubai commented on code in PR #4392:
URL: https://github.com/apache/amoro/pull/4392#discussion_r4267258837
##########
.github/workflows/docker-images.yml:
##########
@@ -186,14 +186,27 @@ jobs:
if: ${{ startsWith(github.repository, 'apache/') }}
strategy:
matrix:
- spark: [ "3.5.7" ]
- scala: [ "2.12.15" ]
+ include:
+ - spark: "3.5.7"
+ scala: "2.12.15"
+ scala_binary: "2.12"
+ major: "3.5"
+ jdk: "11"
+ profile: "spark-3.5"
+ aws: "2.24.12"
+ - spark: "4.1.3"
+ scala: "2.13.17"
+ scala_binary: "2.13"
+ major: "4.1"
+ jdk: "17"
+ profile: "optimizer-spark-4.1"
+ aws: "2.29.52"
Review Comment:
Could we standardize on AWS SDK 2.29.52. And verify compatibility with Spark
3.5 and the other affected components.
##########
amoro-ams/src/test/java/org/apache/amoro/server/optimizing/TestIcebergV3OptimizingPlanning.java:
##########
@@ -69,23 +71,43 @@
import org.junit.jupiter.params.provider.ValueSource;
import java.nio.file.Path;
+import java.sql.PreparedStatement;
+import java.sql.SQLException;
import java.util.Arrays;
import java.util.Collections;
+import java.util.HashSet;
+import java.util.Set;
import java.util.stream.Collectors;
class TestIcebergV3OptimizingPlanning extends PersistentBase {
@TempDir private Path temp;
+ // Preserve standalone execution without loading DerbyPersistence when the
shared AMS test
+ // environment has already initialized persistence. Loading it would
truncate the shared DB.
+ @SuppressWarnings("unused")
Review Comment:
Are these fixes releated to optimizer spark 4.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
