sivakumar-mahalingam commented on code in PR #4392:
URL: https://github.com/apache/amoro/pull/4392#discussion_r4303889806


##########
.github/workflows/docker-images.yml:
##########
@@ -186,14 +186,27 @@ jobs:
     if: ${{ startsWith(github.repository, 'apache/') }}
     strategy:
       matrix:
-        spark: [ "3.5.7" ]
-        scala: [ "2.12.15" ]
+        include:
+          - spark: "3.5.7"
+            scala: "2.12.15"
+            scala_binary: "2.12"
+            major: "3.5"
+            jdk: "11"
+            profile: "spark-3.5"
+            aws: "2.24.12"
+          - spark: "4.1.3"
+            scala: "2.13.17"
+            scala_binary: "2.13"
+            major: "4.1"
+            jdk: "17"
+            profile: "optimizer-spark-4.1"
+            aws: "2.29.52"

Review Comment:
   Standardized both Spark optimizer images on AWS SDK 2.29.52 across the 
workflow, build script, and Dockerfile. Spark 3.5.7/3.5.8 builds and local-mode 
tests pass on JDK 11; Spark 4.1.3 passes on JDK 17. Both Docker images also 
passed local Iceberg S3FileIO runtime checks using 2.29.52. Existing Maven SDK 
management remains unchanged. These checks do not cover real AWS credentials or 
S3A.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to