slfan1989 commented on code in PR #4167: URL: https://github.com/apache/amoro/pull/4167#discussion_r3068916788
########## amoro-format-iceberg/src/test/java/org/apache/amoro/io/writer/TestSortedPosDeleteWriterHeapFlush.java: ########## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.amoro.io.writer; + +import static org.junit.jupiter.api.Assertions.assertEquals; + +import org.apache.amoro.BasicTableTestHelper; +import org.apache.amoro.TableFormat; +import org.apache.amoro.catalog.BasicCatalogTestHelper; +import org.apache.amoro.catalog.TableTestBase; +import org.apache.amoro.table.UnkeyedTable; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.FileFormat; +import org.apache.iceberg.MetadataColumns; +import org.apache.iceberg.MetricsModes; +import org.apache.iceberg.StructLike; +import org.apache.iceberg.TestHelpers; +import org.apache.iceberg.data.GenericAppenderFactory; +import org.apache.iceberg.data.Record; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import java.io.IOException; +import java.util.Arrays; +import java.util.List; +import java.util.stream.Collectors; + +public class TestSortedPosDeleteWriterHeapFlush extends TableTestBase { + + public TestSortedPosDeleteWriterHeapFlush() { + super( + new BasicCatalogTestHelper(TableFormat.MIXED_ICEBERG), + new BasicTableTestHelper(false, false)); + } + + @BeforeAll + public static void startAms() throws Exception { + TEST_AMS.before(); + } + + @AfterAll + public static void stopAms() { + TEST_AMS.after(); + } + + @BeforeEach + public void setup() throws Exception { + temp.create(); + setupCatalog(); + setupTable(); + } + + @AfterEach + public void tearDown() { + if (getCatalogMeta() != null) { + dropTable(); + dropCatalog(); + } + temp.delete(); + } + + @Test Review Comment: > English Version Thank you very much for your suggestion! I have already added the relevant unit tests. > Chinese Version 非常感谢您的建议，我已经增加了相关的单元测试。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
