slfan1989 commented on code in PR #4167:
URL: https://github.com/apache/amoro/pull/4167#discussion_r3068893313


##########
amoro-format-iceberg/src/main/java/org/apache/amoro/io/writer/SortedPosDeleteWriter.java:
##########
@@ -98,7 +174,9 @@ public SortedPosDeleteWriter(
         mask,
         index,
         partitionKey,
-        DEFAULT_RECORDS_NUM_THRESHOLD);
+        DEFAULT_RECORDS_NUM_THRESHOLD,
+        TableProperties.POS_DELETE_FLUSH_HEAP_RATIO_DEFAULT,

Review Comment:
   > English Version
   
   Thank you very much for reviewing the code and I apologize for the delayed 
response. We recently had to handle some urgent production changes, which 
delayed the code updates. We really appreciate you pointing out this issue, and 
it has now been fixed in the latest commit.
   
   > Chinese Version
   
   非常感谢您帮忙 review 
代码,也很抱歉回复得有些晚。最近线上有一些紧急变更需要处理,导致代码修改有所延迟。再次感谢您指出这个问题,我们已经在最新的提交中完成了修复。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to