slfan1989 commented on code in PR #4167:
URL: https://github.com/apache/amoro/pull/4167#discussion_r3068911775
##########
amoro-format-iceberg/src/main/java/org/apache/amoro/io/writer/SortedPosDeleteWriter.java:
##########
@@ -132,9 +234,7 @@ public void delete(CharSequence path, long pos, T row) {
records += 1;
- // TODO Flush buffer based on the policy that checking whether whole heap
memory size exceed the
- // threshold.
- if (records >= recordsNumThreshold) {
+ if (records >= recordsNumThreshold || shouldFlushByHeap()) {
Review Comment:
> English Version
Already implemented at L238-246. Heap usage is sampled every
`heapFlushMinRecords` records (default 1000) to avoid per-delete JVM query
overhead.
> Chinese Version
已经在L238-246进行了修复，每隔 `heapFlushMinRecords` 条记录（默认 1000
条）对堆使用情况进行采样，以避免每次删除操作都产生 JVM 查询开销。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
