shlomitubul commented on PR #64763:
URL: https://github.com/apache/airflow/pull/64763#issuecomment-4229149463
Addressed Copilot review — the multi-annotation bug was a real catch:
**Comment 1 (tplDict multi-annotation)** — Valid bug. The `printf` approach
with `{{-` whitespace trimming concatenated multiple annotations into one YAML
line. Replaced with dict-building + `toYaml` which handles any number of
entries correctly. Also added `toString` for non-string value safety.
**Comment 2 (multi-annotation test)** — Added
`test_tpl_rendered_multiple_annotations` verifying 3 annotations (2 templated +
1 plain) render correctly.
**Comment 3 (webserverConfigConfigMapName test)** — Skipping. The `tpl`
wrapping on these helpers is a one-line change that returns the string
unchanged for non-template values. The existing test at
`test_webserver.py:1010` already exercises the static path. Low risk, not worth
the test complexity.
All 83 tests pass locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
