Miretpl commented on PR #64763: URL: https://github.com/apache/airflow/pull/64763#issuecomment-4215524035
> Removed the kubernetes worker SA test — workers.kubernetes.serviceAccount doesn't propagate to the worker SA template (it only affects the pod-template-file); the worker SA reads from workers.serviceAccount merged via workers.celery @shlomitubul it works in a little different way. The `workers.celery` configuration only affects the rendering for celery workers deployments with the whole overwrite logic of `workers.celery` to `workers`. The `pod-template-file` is not affected by it in any form, and it uses the workers service account or dedicated workers kubernetes service account (if `workers.kubernetes.serviceAccount.create=true`) with respective fields and fallbacks, so basically in current form we are missing the testing of `workers.serviceAccount.annotations` which is deprecated already and `workers.kubernetes.serviceAccount` (which is kinda ok as this PR does not modify the content of `workers-kubernetes-serviceaccount.yaml` file -> "kinda ok" as it will be not strightforward from user perspective why we support template annotations in most of the places, but not in this one). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
