shlomitubul commented on PR #64763:
URL: https://github.com/apache/airflow/pull/64763#issuecomment-4206172419

   @Miretpl Thanks for the thorough review! All feedback addressed in the 
latest commit:
   
   - **tplDict helper**: Removed `nindent` — now generic, indent controlled at 
call sites
   - **Tests restructured**: Deleted `test_tpl_rendering.py`, moved annotation 
tests to `test_annotations.py` and metadata connection tests to 
`test_metadata_connection_secret.py`
   - **No conditional test logic**: Split Airflow 2.x/3.x into separate 
parametrized test methods
   - **result-backend nit**: Fixed
   
   Will also set up pre-commit hooks as suggested. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to