aaron.ballman added a comment. In https://reviews.llvm.org/D47290#1113412, @jfb wrote:
> In https://reviews.llvm.org/D47290#1113365, @aaron.ballman wrote: > > > This is relaxing `-Wformat` and making users instead write > > `-Wformat-pedantic` to get the strong guarantees, which is the opposite of > > what I thought the consensus was. Have I misunderstood something? > > > From Shoaib's email: > > > Based on all the discussion so far, I think the consensus is that we don't > > want to relax -Wformat by default, but an additional relaxed option would > > be fine. That works for me (where I can just switch my codebases to use the > > new warning option), but it wouldn't handle JF Bastien's use case, so he > > would still want to pursue the relaxations specific to Apple platforms. > > This patch is specific to the Darwin platform, as proposed in Alex' original > patch and as I promised to do in the cfe-dev thread. Shoaib's follow-up would > be different and do what I think you're referring to. There were several people on the thread asking to not relax -Wformat for any target, but instead wanted a separate warning flag to perform a more relaxed check. http://lists.llvm.org/pipermail/cfe-dev/2018-May/057938.html http://lists.llvm.org/pipermail/cfe-dev/2018-May/058030.html http://lists.llvm.org/pipermail/cfe-dev/2018-May/058039.html Repository: rC Clang https://reviews.llvm.org/D47290 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
