denzor200 wrote:

> Personally I don't think this is a `performance` check. Boolean operators are 
> for bools; bitwise operators are for ints. I would put this in `readability` 
> or `misc` instead.

I've put this in the performance section because evaluating only one 
operand(which will be in most cases) takes less time than evaluating both 
operands.

I think no place for this check in readability section - someone might say that 
`a &= b;` has better readabilitiness than `a = a && b;`

https://github.com/llvm/llvm-project/pull/142324
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to