denzor200 wrote: > Actually, another reason for not putting this in performance is that the > changes made by this check may lead to non-functional changes in the code. If > the RHS operand is a function that has side effects, this check will change > the logic of the code, since the RHS may not be called due to > short-circuiting, and maybe the caller actually intended to do so.
Do you mean automatic changes made by this check? Don't worry about that, already under control. The check can recognize side effects. https://github.com/llvm/llvm-project/pull/142324 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
