iana marked an inline comment as done.
iana added a comment.

In D157757#4592766 <https://reviews.llvm.org/D157757#4592766>, @philnik wrote:

> I think these changes would allow us to drop the `stddef.h` compat header 
> from libc++, which would be really nice.

I'd really rather not change how `nullptr_t` gets declared in this change, can 
we do these in another one?



================
Comment at: clang/lib/Headers/stddef.h:118-122
+#ifdef __cplusplus
+namespace std {
+typedef decltype(nullptr) nullptr_t;
+}
+using ::std::nullptr_t;
----------------
aaron.ballman wrote:
> Related:
> 
> https://github.com/llvm/llvm-project/issues/37564
> https://cplusplus.github.io/LWG/issue3484
> 
> CC @ldionne
I don't _think_ this change actually changes the way nullptr_t gets defined in 
C++, does it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157757/new/

https://reviews.llvm.org/D157757

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to