sunfish added a comment. In D150803#4419436 <https://reviews.llvm.org/D150803#4419436>, @sbc100 wrote:
> Did you mean to comment on the old PR? This new PR doesn't propose either > "jspi" or "async", but adds that ability to define custom attributes.. since > that was deemed more flexible and forward thinking. The decision as to > which name emscripten will use for what can then be part of different > discussion/PR we hope. Ah, I think I somehow was looking at the old PR, and thought there was a test with `custom_section.func_attr.async` in it. This patch looks ok, though my initial impression is that if we're going to have a fully general-purpose mechanism like this, we might want to plan ahead for attributes that have parameters. We don't need to implement it now though; if there's a reasonable way to evolve in that direction, then this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D150803 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
