tbaeder marked an inline comment as done. tbaeder added inline comments.
================ Comment at: clang/test/Driver/caret-diagnostics-max-lines.cpp:1 +//RUN: not %clang++ -fsyntax-only -fcaret-diagnostics-max-lines=2 %s 2>&1 | FileCheck %s -strict-whitespace + ---------------- MaskRay wrote: > The `test/Driver` test just tests that `-fcaret-diagnostics-max-lines=2` is > forwarded to CC1. The semantic tests are performed in other test directories, > `Misc/caret-diags-multiline.cpp` in this case. Do you want me to remove the semantic part in this file or add a `RUN` line to `caret-diags-multiline.cpp` using `%clang`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152090/new/ https://reviews.llvm.org/D152090 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
